Re: pgsql: pg_upgrade: simplify code layout in a few places - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pgsql: pg_upgrade: simplify code layout in a few places
Date
Msg-id CA+TgmoY-7Zr-oNePrbC1rs_HTGv6Biy8STu5hfGE3_Z_bmgOiA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: pg_upgrade: simplify code layout in a few places  (Bruce Momjian <bruce@momjian.us>)
Responses Re: pgsql: pg_upgrade: simplify code layout in a few places
List pgsql-hackers
On Fri, Jan 5, 2018 at 2:24 PM, Bruce Momjian <bruce@momjian.us> wrote:
> On Fri, Jan  5, 2018 at 02:20:59PM -0500, Robert Haas wrote:
>> On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian <bruce@momjian.us> wrote:
>> > pg_upgrade:  simplify code layout in a few places
>> >
>> > Backpatch-through: 9.4 (9.3 didn't need improving)
>>
>> Hmm.  We don't normally do things like this, because it breaks translatability.
>
> Oh, you mean the 'if()' statement?  If so, I will revert that and add a
> comment so I don't do it again in that place.

Yeah.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: [HACKERS] Pluggable storage
Next
From: Alvaro Herrera
Date:
Subject: Re: pgsql: pg_upgrade: simplify code layout in a few places