Re: pgsql: pg_upgrade: simplify code layout in a few places - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pgsql: pg_upgrade: simplify code layout in a few places
Date
Msg-id 20180105192454.GA15186@momjian.us
Whole thread Raw
In response to Re: pgsql: pg_upgrade: simplify code layout in a few places  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: pgsql: pg_upgrade: simplify code layout in a few places
Re: pgsql: pg_upgrade: simplify code layout in a few places
List pgsql-hackers
On Fri, Jan  5, 2018 at 02:20:59PM -0500, Robert Haas wrote:
> On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian <bruce@momjian.us> wrote:
> > pg_upgrade:  simplify code layout in a few places
> >
> > Backpatch-through: 9.4 (9.3 didn't need improving)
> 
> Hmm.  We don't normally do things like this, because it breaks translatability.

Oh, you mean the 'if()' statement?  If so, I will revert that and add a
comment so I don't do it again in that place.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pgsql: pg_upgrade: simplify code layout in a few places
Next
From: Alvaro Herrera
Date:
Subject: Re: BUGFIX: standby disconnect can corrupt serialized reorder buffers