Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAINoutput in PG11 - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAINoutput in PG11
Date
Msg-id CA+OCxozxjz+m=zy_AN4QPQtNHKuYTpQ6YpihoS=ugpzLe_jvEQ@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAINoutput in PG11  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAINoutput in PG11  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Hi

On Fri, Jun 29, 2018 at 9:55 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the RM #3397 Add support for JIT stats in EXPLAIN output in PG11. Please review it.

A couple of immediate thoughts:

- When the canvas is first rendered, there's a vertical scrollbar now. As soon as I mouseover the new icon, it vanishes and the icon jumps to the right.

- The icon seems lighter than the other controls on the left.

- The icon isn't disabled when there is no info to show.

Thanks. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Aditya Toshniwal
Date:
Subject: Re: [pgAdmin4][RM3294] User need to reset the layout to see thechanged preferences parameters
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Prep 3.2 release notes page.