Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website
Date
Msg-id CA+OCxoy_TUdmca3pB1hgnRKniwQ8-XsKD_2uVTZW9BnTiVuGEA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
Responses Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
List pgadmin-hackers
Hi

On Wed, Aug 19, 2020 at 10:20 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Dave/Team,

As per discussion with the UX team, Few updates on style-guide patch.
1. I have missed removing the "proposed" keyword from the "High-Contract" theme name.

Right.
 
2. I have not added the "Writing Style" section in the style guide as we don’t have the information for it (UX design is also pending due to this). @Dave Page can you provide some inputs on it.

Sure; not sure how to deal with that yet - we'll proceed without it for now.

A couple of other issues I found:

- Random scrollbars:

Screenshot 2020-08-20 at 09.00.38.png

 - On the Menu section, there is a subsection for "Sub menus" (I realise you didn't design that, but...). That doesn't seem right; what is described as a sub menu there is actually a tab set. Can you move it to a separate section please?

There are a few wording changes I'd like as well, but I can deal with that when I'm committing.

Nice work - thanks!



Regards,
Nikhil Mohite.

On Wed, Aug 19, 2020 at 11:40 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have updated the style guide for the pgAdmin 4 website as per RM-5990.
Details :
1. The updated style-guide section as per the new UI design.
2. Added new icons as per font-awesome 5.14.0.
3. Added custom icons of pgAdmin4.

PFA the patch.


Regards,
Nikhil Mohite.


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

Attachment

pgadmin-hackers by date:

Previous
From: Nikhil Mohite
Date:
Subject: Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Added SQL Formatter support in Query Tool. Fixes #204