Re: [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework
Date
Msg-id CA+OCxoyJHSgta=MXGZ71WBQP1iFFrCOXZ61W4NxymLO9SZPttA@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
List pgadmin-hackers
Hi

On Tue, Jun 7, 2016 at 9:44 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi,
>
> Please find the patch with following changes:
> 1. Added help button to the bottom left of the wizard framework.
> Usage:
> Set wizard_help property with url while creating wizard object.
>
> var wizard = new (pgBrowser.Wizard.extend({
>   options: {
>     title: _('Wizard Title'),
>     wizard_help: "{{ url_for('help.static', filename='grant_wizard.html')
> }}"
>   }
> })
>
> 2. Previously wizard progress bar was in bottom left of the wizard framework
> in place of help button.
> So, It is now moved to top of Wizard page.
>
> 3. Added class col-xs-* to the wizard div to be more consistent.
>
> 4. Set proper height for wizard-right-panel_content in css.

Is part of the patch missing? The only visible changes I see are that
the buttons are now misaligned (see attached) - note that it's only on
the first page, and only when first opened. There's no sign of a help
button.

Also - we'd need to make the dialogue non-modal right? Otherwise, how
would the user read the help?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Patch]: RM#1277 - Few cosmetic issues with preference dialog
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Cleanup a couple of issues missed when the Windows in