Re: 答复: [pgadmin-hackers] pgAdmin III commit: Fix SQL for GRANT on a sequence - Mailing list pgadmin-hackers

From Dave Page
Subject Re: 答复: [pgadmin-hackers] pgAdmin III commit: Fix SQL for GRANT on a sequence
Date
Msg-id CA+OCxoxPoYZrUAJQO2rcg8_CUd21OF4uSi76xPjxBPbHbz80Jg@mail.gmail.com
Whole thread Raw
In response to pgAdmin III commit: Fix SQL for GRANT on a sequence  (Guillaume Lelarge <guillaume@lelarge.info>)
Responses Re: [pgadmin-hackers] Re: 答复: [pgadmin-hackers] pgAdmin III commit: Fix SQL for GRANT on a sequence  (Guillaume Lelarge <guillaume@lelarge.info>)
List pgadmin-hackers



On Tue, Jul 15, 2014 at 2:45 AM, liuyuanyuan <liuyuanyuangogo@gmail.com> wrote:

Thanks for your attention to this topic!

In fact, none pgadmin can be compatible with all  versions of the database.


We've done pretty well so far, supporting right back to 7.3, through we don't officially support the much older versions now, but that's mostly due to the amount of testing it requires.
 

Although earlier versions of PG don't support GRANT ON SEQUENCE,

but new versions support. So I think this adjustment is necessary .


Old versions supported GRANT ON TABLE for sequences iirc, (as sequences are members of pg_class). This change is only necessary if newer versions of PostgreSQL dropped that syntax. It may be desirable, if we no longer support any versions of PostgreSQL that needed the old syntax.
 

 

Jasmine

 

发件人: pgadmin-hackers-owner@postgresql.org [mailto:pgadmin-hackers-owner@postgresql.org] 代表 Dave Page
发送时间: 2014715 6:28
收件人: Guillaume Lelarge
抄送: pgadmin-hackers@postgresql.org
主题: Re: [pgadmin-hackers] pgAdmin III commit: Fix SQL for GRANT on a sequence

 

Minor brain failure, but I believe the same comment applies.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On 14 Jul 2014, at 22:13, Guillaume Lelarge <guillaume@lelarge.info> wrote:

2014-07-14 23:09 GMT+02:00 Dave Page <dpage@pgadmin.org>:

That syntax was (once) intentional, and was not a bug, as earlier versions of PG don't support ALTER SEQUENCE. Did you check the version compatibility?

 

I'm not sure I understand what you mean. We're not talking about ALTER SEQUENCE. We're talking about GRANT ON SEQUENCE.
 

-- 
Dave Page
Blog: 
http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK:
http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On 14 Jul 2014, at 22:03, Guillaume Lelarge <guillaume@lelarge.info> wrote:

Fix SQL for GRANT on a sequence

Report from liuyuanyuan.

Branch
------
REL-1_18_0_PATCHES

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=5eb8e16348c001708d4b2d511eae988724a84938

Modified Files
--------------
CHANGELOG                     |    2 ++
pgadmin/dlg/dlgSequence.cpp   |    2 +-
pgadmin/schema/pgSequence.cpp |    2 +-
3 files changed, 4 insertions(+), 2 deletions(-)


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pgAdmin III commit: Fix SQL for GRANT on a sequence
Next
From: Dave Page
Date:
Subject: Re: PATCH: saving macro after query pasting