Re: Debugger line numbering is off by one - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Debugger line numbering is off by one
Date
Msg-id CA+OCxowfSryzjNHi8AMdA13gzEwmpBC3YL_58PJLFHCMxaQfag@mail.gmail.com
Whole thread Raw
In response to Debugger line numbering is off by one  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Responses Re: Debugger line numbering is off by one
List pgadmin-hackers
On Wed, Apr 25, 2012 at 11:24 AM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
>
> The hack that was removed skipped an initial newline when counting line
> numbers. The PL/pgSQL debugger has a similar hack, but it didn't get the
> memo that it was removed in the backend, so the green current line marker is
> off by one when connected to a 9.1 server. Attached is a patch to fix that.

Hi

It looks fine, except that the "Paused at line" message in the status
bar is still off by one. I tried using the offset you calculated there
as well, and things started getting really weird (like, starting on
line -15, then after single stepping, going back to being 1 off). I
assume that the offset is being used there before it's actually
calculated, but don't have time to play further right now.

Can you fix it please?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Debugger line numbering is off by one
Next
From: Dave Page
Date:
Subject: pgAdmin III commit: Silence a GCC warning.