Debugger line numbering is off by one - Mailing list pgadmin-hackers

From Heikki Linnakangas
Subject Debugger line numbering is off by one
Date
Msg-id 4F97D0EE.7000403@enterprisedb.com
Whole thread Raw
Responses Re: Debugger line numbering is off by one
List pgadmin-hackers
In PostgreSQL 9.1, the line numbering of PL/pgSQL functions was changed
by this commit:

> commit c3a05881de21438a29b6dc721ebd7d1e028a905a
> Author: Robert Haas <rhaas@postgresql.org>
> Date:   Mon Aug 2 03:46:54 2010 +0000
>
>     Remove ancient PL/pgsql line numbering hack.
>
>     While this hack arguably has some benefit in terms of making PL/pgsql's
>     line numbering match the programmer's expectations, it also makes
>     PL/pgsql inconsistent with the remaining PLs, making it difficult for
>     clients to reliably determine where the error actually is.  On balance,
>     it seems better to be consistent.
>
>     Pavel Stehule

The hack that was removed skipped an initial newline when counting line
numbers. The PL/pgSQL debugger has a similar hack, but it didn't get the
memo that it was removed in the backend, so the green current line
marker is off by one when connected to a 9.1 server. Attached is a patch
to fix that.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

Attachment

pgadmin-hackers by date:

Previous
From: Thom Brown
Date:
Subject: Re: Incorrect domain logic for 9.1
Next
From: Dave Page
Date:
Subject: Re: Debugger line numbering is off by one