Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
Date
Msg-id C2316C94-FE4C-4969-94DA-D7C4FDE3DA31@yesql.se
Whole thread Raw
In response to Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
> On 15 Sep 2023, at 16:38, Nathan Bossart <nathandbossart@gmail.com> wrote:

> this should use errdetail() instead of errhint().  In
> the provided patch, the new message explains how the module is not
> configured.  It doesn't hint at how to fix it (although presumably one
> could figure that out pretty easily).

Fair point, I agree with your reasoning that errdetail seems more appropriate.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
Next
From: Nathan Bossart
Date:
Subject: Re: bug fix and documentation improvement about vacuumdb