Re: bug fix and documentation improvement about vacuumdb - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: bug fix and documentation improvement about vacuumdb
Date
Msg-id 20230915144210.GB1912920@nathanxps13
Whole thread Raw
In response to Re: bug fix and documentation improvement about vacuumdb  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: bug fix and documentation improvement about vacuumdb
List pgsql-hackers
On Fri, Sep 15, 2023 at 10:13:10AM +0200, Daniel Gustafsson wrote:
>> On 15 Sep 2023, at 04:39, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
>> It seems to work fine. However, if we're aiming for consistent
>> spacing, the "IS NULL" (two spaces in between) might be an concern.
> 
> I don't think that's a problem.  I would rather have readable C code and two
> spaces in the generated SQL than contorting the C code to produce less
> whitespace in a query few will read in its generated form.

I think we could pretty easily avoid the extra space and keep the C code
relatively readable.  These sorts of things bug me, too (see 2af3336).

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
Next
From: Heikki Linnakangas
Date:
Subject: Re: Unlogged relations and WAL-logging