Re: CREATE REPLICATION SLOT fails on a timeout - Mailing list pgsql-hackers

From Steve Singer
Subject Re: CREATE REPLICATION SLOT fails on a timeout
Date
Msg-id BLU0-SMTP76E5D6291A37B1387D362DC310@phx.gbl
Whole thread Raw
In response to Re: CREATE REPLICATION SLOT fails on a timeout  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: CREATE REPLICATION SLOT fails on a timeout
List pgsql-hackers
On 05/16/2014 04:43 PM, Andres Freund wrote:
> Hi,
>
> I don't think that's going to cut it though. The creation can take
> longer than whatever wal_sender_timeout is set to (when there's lots of
> longrunning transactions). I think checking whether last_reply_timestamp
> = 0 during timeout checking is more robust.
>
> Greetings,
>
> Andres Freund
>
>


That makes sense.
A patch that does that is attached.

Steve

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: CREATE REPLICATION SLOT fails on a timeout
Next
From: Thomas Munro
Date:
Subject: Re: SKIP LOCKED DATA (work in progress)