Re: CREATE REPLICATION SLOT fails on a timeout - Mailing list pgsql-hackers

From Andres Freund
Subject Re: CREATE REPLICATION SLOT fails on a timeout
Date
Msg-id 20140516233425.GD9100@awork2.anarazel.de
Whole thread Raw
In response to Re: CREATE REPLICATION SLOT fails on a timeout  (Steve Singer <steve@ssinger.info>)
Responses Re: CREATE REPLICATION SLOT fails on a timeout  (andres@anarazel.de (Andres Freund))
List pgsql-hackers
On 2014-05-16 17:02:33 -0400, Steve Singer wrote:
> >I don't think that's going to cut it though. The creation can take
> >longer than whatever wal_sender_timeout is set to (when there's lots of
> >longrunning transactions). I think checking whether last_reply_timestamp
> >= 0 during timeout checking is more robust.

> That makes sense.
> A patch that does that is attached.

I've attached a heavily revised version of that patch. Didn't touch all
the necessary places...

Survives creation of logical replication slots under 'intensive
pressure', with a wal_sender_timeout=10ms.

Thanks for the bugreport!

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: %d in log_line_prefix doesn't work for bg/autovacuum workers
Next
From: Robert Haas
Date:
Subject: Re: Scaling shared buffer eviction