Re: pl/python SPI in subtransactions - Mailing list pgsql-hackers

From Steve Singer
Subject Re: pl/python SPI in subtransactions
Date
Msg-id BLU0-SMTP275B49B34200AC4A7F053C8EE00@phx.gbl
Whole thread Raw
In response to Re: pl/python SPI in subtransactions  (Jan Urbański <wulczer@wulczer.org>)
Responses Re: pl/python SPI in subtransactions  (Jan Urbański <wulczer@wulczer.org>)
List pgsql-hackers
On 11-01-29 03:39 PM, Jan Urbański wrote:
>
> D'oh, you're right, thanks. Attached patch with fix. Curiosly, right now
> in master your example with plpy.prepare will result in "savepoint"
> being swallowed, but it's of course better to react with an error.
>
> Cheers,
> Jan

This seems to fix it.

You mentioned that you were going to add a few paragraphs to the 
documentation saying that you can now actually catch SPI errors. I 
haven't seen that yet.

Other than that I don't see any issues with the patch and it should be 
ready for a committer.


>
>



pgsql-hackers by date:

Previous
From: Jan Urbański
Date:
Subject: Re: pl/python SPI in subtransactions
Next
From: Jan Urbański
Date:
Subject: Re: pl/python SPI in subtransactions