On 29/01/11 22:10, Steve Singer wrote:
> On 11-01-29 03:39 PM, Jan Urbański wrote:
>>
>> D'oh, you're right, thanks. Attached patch with fix. Curiosly, right now
>> in master your example with plpy.prepare will result in "savepoint"
>> being swallowed, but it's of course better to react with an error.
>>
>> Cheers,
>> Jan
>
> This seems to fix it.
>
> You mentioned that you were going to add a few paragraphs to the
> documentation saying that you can now actually catch SPI errors. I
> haven't seen that yet.
Yeah, I'm procrastinating the doc writing part ;) Will spit something
out by the end of the (CET) day.
> Other than that I don't see any issues with the patch and it should be
> ready for a committer.
Great, thanks for a diligent review,
Jan
