Re: GIN pageinspect support for entry tree and posting tree - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: GIN pageinspect support for entry tree and posting tree
Date
Msg-id BFCA6110-EC97-4569-917A-747A72F62CE8@yandex-team.ru
Whole thread Raw
In response to Re: GIN pageinspect support for entry tree and posting tree  (Kirill Reshke <reshkekirill@gmail.com>)
List pgsql-hackers

> On 10 Jan 2026, at 19:17, Kirill Reshke <reshkekirill@gmail.com> wrote:
>
> So,
> v14-0004 with this change attached.

Did you mean 0003?

The change makes sense, but I'd note that macro is always used like this:

if (!IS_INDEX(indexRel) || !IS_HASH(indexRel))

If we are refactoring this, maybe put IS_INDEX inside of corresponding IS_BTREE(),IS_GIN() and IS_HASH()?


Best regards, Andrey Borodin.


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: JumbleQuery ma treat different GROUP BY expr as the same
Next
From: "David E. Wheeler"
Date:
Subject: Re: ABI Compliance Checker GSoC Project