On Sat, 10 Jan 2026 at 17:15, Japin Li <japinli@hotmail.com> wrote:
> > Your comments refer to v12-0002. For the record, did you review 0001,
> > if yes, do you think it is good? I have included you as a reviewer to
> > v12-0002 commit message.
> >
>
> Yeah, patch 0001 looks good to me.
Thank you. I have updated 0001 commit message.
>
> I noticed that the IS_INDEX macro is currently defined in btreefunc.c,
> hashfuncs.c, and now also in ginfuncs.c. Would it be possible to move it
> to a shared header file so all these modules can include it from one place?
>
This is something I had thought about also. I do find this idea good,
but 0002 patch is already big, and I don't want to overload it. So,
v14-0004 with this change attached.
--
Best regards,
Kirill Reshke
