Postgres Pro
Downloads
Home   >   mailing lists

Re: replace InvalidXid(a macro that doesn't exist) with InvalidTransactionId(a macro that exists) in code comments - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: replace InvalidXid(a macro that doesn't exist) with InvalidTransactionId(a macro that exists) in code comments
Date
Msg-id BEA11ED3-FA35-4F71-9D14-C6521F7234A0@yesql.se
Whole thread Raw
In response to replace InvalidXid(a macro that doesn't exist) with InvalidTransactionId(a macro that exists) in code comments  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Tree view 
> On 4 Oct 2021, at 10:19, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:

> It seems like we have macro InvalidTransactionId but InvalidXid is
> used in some of the code comments.Here's a small patch that does
> $subject?

While I doubt anyone would be confused by these, I do agree it's worth being
consistent and use the right terms. Pushed to master, thanks!

--
Daniel Gustafsson        https://vmware.com/

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Remove an obsolete comment in snapbuild.c
Next
From: Alexander Lakhin
Date:
Subject: Re: BUG #17212: pg_amcheck fails on checking temporary relations