Re: Another pgindent gripe - Mailing list pgsql-hackers

From Chuck McDevitt
Subject Re: Another pgindent gripe
Date
Msg-id BB05A27C22288540A3A3E8F3749B45AB023246FB@MI8NYCMAIL06.Mi8.com
Whole thread Raw
In response to Another pgindent gripe  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Another pgindent gripe  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Pgindent adds spaces after the stars if it doesn't recognize the thing
before the star as a typedef... Could it be that somehow the list of
typedefs included in pgindent got corrupted?

> -----Original Message-----
> From: pgsql-hackers-owner@postgresql.org [mailto:pgsql-hackers-
> owner@postgresql.org] On Behalf Of Tom Lane
> Sent: Monday, November 07, 2005 8:19 AM
> To: Neil Conway
> Cc: Bruce Momjian; Hackers
> Subject: Re: [HACKERS] Another pgindent gripe
>
> Neil Conway <neilc@samurai.com> writes:
> > On a related note, most of these changes are completely bogus:
>
> >
>
http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_e
xe
> c.c.diff?r1=1.152;r2=1.153
>
> Oy vey!  Why did it insert spaces after the stars in all those
function
> declarations?  That's certainly not in conformance with project style
> ... and I don't see it having happened elsewhere.
>
> Seems like pgindent has suffered some significant regressions since
the
> 8.0 run.  I thought it had not been changed much at all, but evidently
> that's wrong.
>
>             regards, tom lane
>
> ---------------------------(end of
broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings




pgsql-hackers by date:

Previous
From: Marc Munro
Date:
Subject: Odd db lockup - investigation advice wanted
Next
From: karen hill
Date:
Subject: DTrace?