Re: pg_upgrade defaulting to port 25432 - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pg_upgrade defaulting to port 25432
Date
Msg-id BANLkTikzk+6hOR7jN2U-6e383-5StrjUcA@mail.gmail.com
Whole thread Raw
In response to Re: pg_upgrade defaulting to port 25432  (Bruce Momjian <bruce@momjian.us>)
Responses Re: pg_upgrade defaulting to port 25432
List pgsql-hackers
On Mon, Jun 27, 2011 at 2:19 PM, Bruce Momjian <bruce@momjian.us> wrote:
> Robert Haas wrote:
>> On Mon, Jun 27, 2011 at 1:59 PM, Bruce Momjian <bruce@momjian.us> wrote:
>> > Robert Haas wrote:
>> >> On Mon, Jun 27, 2011 at 1:49 PM, Bruce Momjian <bruce@momjian.us> wrote:
>> >> > OK, fair enough. ?Should I apply my ports patch to Postgres 9.2?
>> >>
>> >> I'm not sure which patch you are referring to.
>> >
>> > This one which makes 50432 the default port.
>>
>> There appear to be some other changes mixed into this patch.
>
> The additional changes were to have the existing environment variables
> begin with "PG", as requested.

It's easier to read the patches if you do separate changes in separate
patches.  Anyway, I'm a bit nervous about this hunk:

+         if (old_cluster.port == DEF_PGUPORT)
+             pg_log(PG_FATAL, "When checking a live old server, "
+                    "you must specify the old server's port number.\n");

Is the implication here that I'm now going to need to specify more
than 4 command-line options/environment variables for this to work?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: SSI modularity questions
Next
From: Bruce Momjian
Date:
Subject: Re: pg_upgrade defaulting to port 25432