Re: Fix for pg_upgrade user flag - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Fix for pg_upgrade user flag
Date
Msg-id BANLkTikxNYAaagiakyLniwmd07FowtCnYQ@mail.gmail.com
Whole thread Raw
In response to Re: Fix for pg_upgrade user flag  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Fix for pg_upgrade user flag  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Sat, May 7, 2011 at 9:50 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Sat, May 7, 2011 at 8:56 AM, Bruce Momjian <bruce@momjian.us> wrote:
>> The attached, applied patch checks that the pg_upgrade user specified is
>> a super-user.  It also reports the error message when the post-pg_ctl
>> connection fails.
>>
>> This was prompted by a private bug report from EnterpriseDB.
>
> It strikes me that it's fairly crazy to think you're going to be able
> to catch all the possible errors the server might throw this way.
> Don't we need some way of letting the actual server errors leak out?

Or, hmm.  Maybe you just did that.  If so, never mind.  :-)

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Why not install pgstattuple by default?
Next
From: Robert Haas
Date:
Subject: Re: patch for new feature: Buffer Cache Hibernation