Re: patch: Allow \dd to show constraint comments - Mailing list pgsql-hackers

From Kohei KaiGai
Subject Re: patch: Allow \dd to show constraint comments
Date
Msg-id BANLkTi=YBCZ3OzqOCoJ-nP6cnNTiVz7Gqg@mail.gmail.com
Whole thread Raw
In response to Re: patch: Allow \dd to show constraint comments  (Josh Kupershmidt <schmiddy@gmail.com>)
Responses Re: patch: Allow \dd to show constraint comments
List pgsql-hackers
I think the v5 patch should be marked as 'Ready for Committer'

2011/6/18 Josh Kupershmidt <schmiddy@gmail.com>:
> On Sat, Jun 18, 2011 at 10:53 AM, Kohei KaiGai <kaigai@kaigai.gr.jp> wrote:
>> In addition, this pg_comments system view supports 'access method' class, but
>> we cannot set a comment on access methods using COMMENT ON statement.
>
> Well, there are comments for the built-in access methods, i.e.
>
Oops, I missed the comments on initdb stage.

>> Regarding to the data-type of objnamespace, how about an idea to define a new
>> data type such as 'regschema' and cast objnamespace into this type?
>> If we have such data type, user can reference string expression of schema name,
>> and also available to use OID joins.
>
> Are you suggesting we leave the structure of pg_comments unchanged,
> but introduce a new 'regschema' type so that if users want to easily
> display the schema name of an object, they can just do:
>
>  SELECT objnamespace::regschema, ...
>    FROM pg_comments WHERE ... ;
>
> That seems reasonable to me.
>
Yes, however, it should be discussed in another thread as Robert said.

Thanks,
--
KaiGai Kohei <kaigai@kaigai.gr.jp>


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: SSI tuning points
Next
From: Kohei KaiGai
Date:
Subject: Re: [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address