Re: Re: [COMMITTERS] pgsql: Redefine _() to dgettext() instead of gettext() so that it uses - Mailing list pgsql-hackers

From Hiroshi Saito
Subject Re: Re: [COMMITTERS] pgsql: Redefine _() to dgettext() instead of gettext() so that it uses
Date
Msg-id B931FEADCC0D4A1799C008E7C7D6777A@HIRO57887DE653
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Redefine _() to dgettext() instead of gettext() so that it uses  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Hi Peter-san.

I see the problem for being an original domain in plpgsql. It differs from what
codeset meant at postmaster by Japanese windows....
Please see, this look at the problem on which SJIS enters into a message.
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/plpgsql/before_plpgsql_server.log
This state is the following.
==
lc_messages=ja
server_encoding=utf-8
==

Therefore,  it needs to be codeset called for an original domain. It is the procedure in which
only a server module must correspond. Then, It is solvable by this patch.
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/plpgsql/after_plpgsql_server.log

Please take this into consideration.
Tahnks.

Regards,
Hiroshi Saito

----- Original Message -----
From: "Peter Eisentraut" <peter_e@gmx.net>


> Alvaro Herrera wrote:
>> Peter Eisentraut wrote:
>>> Log Message:
>>> -----------
>>> Redefine _() to dgettext() instead of gettext() so that it uses the plpgsql
>>> text domain, instead of the postgres one (or whatever the default may be).
>>
>> Hmm, so is this needed on all other PLs too?
>
> In principle yes.  Or call dgettext() explicitly, which is also done in
> some cases.  However, in most cases messages are issued through
> ereport(), which handles this automatically (which you implemented, I
> recall).

Attachment

pgsql-hackers by date:

Previous
From: Hannu Krosing
Date:
Subject: Re: xpath processing brain dead
Next
From: Teodor Sigaev
Date:
Subject: Re: regression test crashes at tsearch