Re: Fix for seg picksplit function - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: Fix for seg picksplit function
Date
Msg-id AANLkTinderiVZ11MnSMVDpgr3Em5dJTQfVO0BhO2ULTP@mail.gmail.com
Whole thread Raw
In response to Re: Fix for seg picksplit function  (Yeb Havinga <yebhavinga@gmail.com>)
List pgsql-hackers
Hello Yeb,

Thank you for review and code refactoring.

PS: when comparing with gbt_num_picksplit, I noticed that that one does not update v->spl_ldatum and spl_rdatum to the union datums, but initializes these to 0 at the beginning and never seems to update them. Not sure if this is a problem since the num_picksplit stuff seems to work well.
Actually gbt_num_picksplit updates v->spl_ldatum and spl_rdatum inside gbt_num_bin_union function.
 
----
With best regards,
Alexander Korotkov.

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: why does plperl cache functions using just a bool for is_trigger
Next
From: Dimitri Fontaine
Date:
Subject: Re: ALTER OBJECT any_name SET SCHEMA name