Re: REVIEW: Determining client_encoding from client locale - Mailing list pgsql-hackers

From Ibrar Ahmed
Subject Re: REVIEW: Determining client_encoding from client locale
Date
Msg-id AANLkTinbvV4iuWX9+PGshcWnjtPanrU2uuT-iT2uXrDn@mail.gmail.com
Whole thread Raw
In response to Re: REVIEW: Determining client_encoding from client locale  (Stephen Frost <sfrost@snowman.net>)
Responses Re: REVIEW: Determining client_encoding from client locale
Re: REVIEW: Determining client_encoding from client locale
List pgsql-hackers
Stephen Frost!

I have modified the code to use ADD_STARTUP_OPTION instead of writing code again.
And  tried the patch on Windows  and Linux and it works for me.




On Sun, Feb 6, 2011 at 10:19 AM, Stephen Frost <sfrost@snowman.net> wrote:
Ibrar,

* Ibrar Ahmed (ibrar.ahmad@gmail.com) wrote:
> I have reviewed/tested this patch.

Great, thanks for that!

> In my point code should be like this
>
>      *if (conn->client_encoding_initial && conn->client_encoding_initial[0])
>        {
>                if (packet)
>                {
>                        strcpy(packet + packet_len, "client_encoding");
>                        packet_len += strlen("client_encoding") + 1;
>                        strcpy(packet + packet_len,
> conn->client_encoding_initial);
>                        packet_len += strlen(conn->client_encoding_initial) +
> 1;
>               }
>         }*

Makes sense to me, just reading through this email.  Have you tested
this change..?  Could you provide it as an additional patch or a new
patch including the change against head, assuming it still works well in
your testing?

> I will test this patch on Windows and will send results.

That would be great, it's not easy for me to test under Windows.

       Thanks!

               Stephen

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk1O5joACgkQrzgMPqB3kijODgCeN1/PVKf/qzeuWOz82FwpR/B0
2rMAnR+4tCxNp9eZn7qIOTXqCv70H2oC
=vYXv
-----END PGP SIGNATURE-----




--
   Ibrar Ahmed


Attachment

pgsql-hackers by date:

Previous
From: Shigeru HANADA
Date:
Subject: Re: exposing COPY API
Next
From: Thom Brown
Date:
Subject: Re: [GENERAL] Issues with generate_series using integer boundaries