Re: Drop one-argument string_agg? (was Re: [BUGS] string_agg delimiter having no effect with order by) - Mailing list pgsql-hackers

From Alex Hunsaker
Subject Re: Drop one-argument string_agg? (was Re: [BUGS] string_agg delimiter having no effect with order by)
Date
Msg-id AANLkTinV3VachETZN4Kr1GGUDcVFzEJaEcGO0a=c1cD1@mail.gmail.com
Whole thread Raw
In response to Re: Drop one-argument string_agg? (was Re: [BUGS] string_agg delimiter having no effect with order by)  (Thom Brown <thom@linux.com>)
Responses Re: Drop one-argument string_agg? (was Re: [BUGS] string_agg delimiter having no effect with order by)
List pgsql-hackers
On Wed, Aug 4, 2010 at 16:33, Thom Brown <thom@linux.com> wrote:

> I was afraid that the function would be pulled completely, but from
> looking at the patch, you're only removing the function with a
> single-parameter signature, which is quite innocuous.  So I'm "for"
> now.

Ahh, Now I see why you were worried about people calling you a witch :)

On another note, I do wonder if we could avoid more confusion by just
reordering the arguments.  In-fact I bet the original argument
ordering was done precisely so it would match the 1 argument version.

I dunno about anyone else but (a, ',' order by a) just looks weird.

Or in other words, any thoughts on:
select string_agg(delim, expression);

I don't want to stretch this out, but while we are making changes...


pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: Drop one-argument string_agg? (was Re: [BUGS] string_agg delimiter having no effect with order by)
Next
From: Tom Lane
Date:
Subject: Re: Two different methods of sneaking non-immutable data into an index