Re: pgsql: Support RIGHT and FULL OUTER JOIN in hash joins. - Mailing list pgsql-committers

From Robert Haas
Subject Re: pgsql: Support RIGHT and FULL OUTER JOIN in hash joins.
Date
Msg-id AANLkTinNNV6kr7kmVtoUiQ0SQYxY1HdCk98P9yReQvMJ@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Support RIGHT and FULL OUTER JOIN in hash joins.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Support RIGHT and FULL OUTER JOIN in hash joins.
List pgsql-committers
On Thu, Dec 30, 2010 at 9:55 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> This is cool, but on first blush your changes to
>>> add_paths_to_joinrel() appear to be total nonsense.  I think the
>>> problem is that have_nonmergeable_clause is really a misnomer - it's
>>> not clear until you read through the whole diff that this won't get
>>> set for inner/left joins.
>
>> Yeah, I wasn't totally satisfied with that variable name either.
>> Do you have a better idea?
>
> On reflection, how about inverting the flag's value and calling it
> mergejoin_allowed or some such?

Yeah, that's better.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Move symbols for ExecMergeJoin's state machine into nodeMergejoi
Next
From: Tom Lane
Date:
Subject: pgsql: Invert and rename flag variable to improve code readability.