Re: pgsql: Support RIGHT and FULL OUTER JOIN in hash joins. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Support RIGHT and FULL OUTER JOIN in hash joins.
Date
Msg-id 18368.1293764121@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Support RIGHT and FULL OUTER JOIN in hash joins.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Support RIGHT and FULL OUTER JOIN in hash joins.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-committers
I wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> This is cool, but on first blush your changes to
>> add_paths_to_joinrel() appear to be total nonsense.  I think the
>> problem is that have_nonmergeable_clause is really a misnomer - it's
>> not clear until you read through the whole diff that this won't get
>> set for inner/left joins.

> Yeah, I wasn't totally satisfied with that variable name either.
> Do you have a better idea?

On reflection, how about inverting the flag's value and calling it
mergejoin_allowed or some such?

            regards, tom lane

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Support RIGHT and FULL OUTER JOIN in hash joins.
Next
From: Tom Lane
Date:
Subject: pgsql: Move symbols for ExecMergeJoin's state machine into nodeMergejoi