Re: review: FDW API - Mailing list pgsql-hackers

From Robert Haas
Subject Re: review: FDW API
Date
Msg-id AANLkTin0mPgFMK+t_Tq8J0X69-He0VPkyTPj4AQ6gC7F@mail.gmail.com
Whole thread Raw
In response to Re: review: FDW API  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-hackers
On Mon, Jan 24, 2011 at 8:08 AM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
>> How much review have you done of parts (3) and (4)?  The key issue for
>> all of the FDW work in progress seems to be what the handler API is
>> going to look like, and so once we get that committed it will unblock
>> a lot of other things.
>
> I've gone through the code in a bit more detail now. I did a bunch of
> cosmetic changes along the way, patch attached. I also added a few
> paragraphs in the docs. We need more extensive documentation, but this at
> least marks the places where I think the docs need to go.
>
> Comments:

I haven't seen any responses to these comments.  Time grows short to
get this committed to PostgreSQL 9.1.  We need responses to these
comments and an updated patch ASAP.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Itagaki Takahiro
Date:
Subject: Re: multiset patch review
Next
From: Robert Haas
Date:
Subject: Re: Named restore points