Re: page corruption on 8.3+ that makes it to standby - Mailing list pgsql-hackers

From Robert Haas
Subject Re: page corruption on 8.3+ that makes it to standby
Date
Msg-id AANLkTime4uihZ560OjeopjA5y4L-5DOzanNyjX9je+RE@mail.gmail.com
Whole thread Raw
In response to Re: page corruption on 8.3+ that makes it to standby  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: page corruption on 8.3+ that makes it to standby
List pgsql-hackers
On Thu, Jul 29, 2010 at 4:58 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
> On Wed, 2010-07-28 at 14:22 -0700, Jeff Davis wrote:
>> On Wed, 2010-07-28 at 15:37 -0400, Tom Lane wrote:
>> > So nevermind that distraction.  I'm back to thinking that fix1 is
>> > the way to go.
>>
>> Agreed.
>>
>> It's uncontroversial to have a simple guard against corrupting an
>> uninitialized page, and uncontroversial is good for things that will be
>> back-patched.
>
> Still don't understand why we would not initialize such pages. If we're
> copying a relation we must know enough about it to init a page.

Well, I don't see why we'd want to do that.  As Jeff Davis pointed
out, if someone asks to move a table to a different tablespace,
changing the contents as we go along seems a bit off-topic.  But the
bigger problem is you haven't explained how you think we could
determine what initialization ought to be performed.  There's no
index-AM API that says "initialize this page".  I suppose we could
invent one if there were some benefit, but we couldn't very well
back-patch such a thing to 8.0.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company


pgsql-hackers by date:

Previous
From: Boszormenyi Zoltan
Date:
Subject: Re: lock_timeout GUC patch - Review
Next
From: Pavel Stehule
Date:
Subject: review: xml_is_well_formed