Re: InvalidXLogRecPtr in docs - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: InvalidXLogRecPtr in docs
Date
Msg-id AANLkTil5ZWOxtyWeI1FW-meA7nDelNdo3u_G17pJBgcI@mail.gmail.com
Whole thread Raw
In response to Re: InvalidXLogRecPtr in docs  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: InvalidXLogRecPtr in docs
List pgsql-hackers
On Thu, Jun 10, 2010 at 11:56 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Wed, Jun 9, 2010 at 9:46 PM, Takahiro Itagaki
>> <itagaki.takahiro@oss.ntt.co.jp> wrote:
>>> I found a term "InvalidXLogRecPtr" in 9.0 docs.
>>> http://developer.postgresql.org/pgdocs/postgres/functions-admin.html#FUNCTIONS-RECOVERY-INFO-TABLE
>>> | ... then the return value will be InvalidXLogRecPtr (0/0).
>
>> Maybe we should be returning NULL instead of 0/0.
>
> +1 for using NULL instead of an artificially chosen value, for both of
> those functions.

Okay, the attached patch makes those functions return NULL in that case.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: fix use of posix_fadvise in xlog.c
Next
From: Heikki Linnakangas
Date:
Subject: Re: InvalidXLogRecPtr in docs