Re: Problem with insert - 1.12.0 RC1 - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Problem with insert - 1.12.0 RC1
Date
Msg-id AANLkTi=iyCtCF85SFinDO21DFr+xGe=rhr9samwTT_pd@mail.gmail.com
Whole thread Raw
In response to Re: Problem with insert - 1.12.0 RC1  (Guillaume Lelarge <guillaume@lelarge.info>)
Responses Re: Problem with insert - 1.12.0 RC1
List pgadmin-hackers
On Thu, Sep 2, 2010 at 12:30 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Le 02/09/2010 10:28, Dave Page a écrit :
>> Anyway, can the code in the edit grid be modified to detect the empty
>> pgSet in place of null?
>>
>
> Yeah, by checking how many rows were inserted. See patch attached. It
> fixes the issue. Not sure this is the way we should do it. I'm afraid
> there are other parts in the code where the "return new pgSet();" code
> will bite us.

Looks OK to me. I don't expect many other places will have issues - we
probably would have noticed by now.

Besides, fixing occurrences like this is probably much easier than
making reconnect work after an object has unexpectedly been handled a
null pgSet.



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: Re: Problem with insert - 1.12.0 RC1
Next
From: Guillaume Lelarge
Date:
Subject: pgAdmin III commit: Check the number of rows inserted in frmEditGrid