Re: Problem with insert - 1.12.0 RC1 - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject Re: Problem with insert - 1.12.0 RC1
Date
Msg-id 4C7FC8E9.90500@lelarge.info
Whole thread Raw
In response to Re: Problem with insert - 1.12.0 RC1  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Le 02/09/2010 13:59, Dave Page a écrit :
> On Thu, Sep 2, 2010 at 12:30 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> Le 02/09/2010 10:28, Dave Page a écrit :
>>> Anyway, can the code in the edit grid be modified to detect the empty
>>> pgSet in place of null?
>>>
>>
>> Yeah, by checking how many rows were inserted. See patch attached. It
>> fixes the issue. Not sure this is the way we should do it. I'm afraid
>> there are other parts in the code where the "return new pgSet();" code
>> will bite us.
>
> Looks OK to me. I don't expect many other places will have issues - we
> probably would have noticed by now.
>
> Besides, fixing occurrences like this is probably much easier than
> making reconnect work after an object has unexpectedly been handled a
> null pgSet.
>

OK, commited.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: pgAdmin III commit: Check the number of rows inserted in frmEditGrid
Next
From: Guillaume Lelarge
Date:
Subject: pgAdmin III commit: Fix an issue when editing date value in frmEditGrid