Re: Add support for logging the current role - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Add support for logging the current role
Date
Msg-id AANLkTi=+D+oH-a5dq0fdSfBoFyvd1PkycgGmm1_MD_SP@mail.gmail.com
Whole thread Raw
In response to Add support for logging the current role  (Stephen Frost <sfrost@snowman.net>)
Responses Re: Add support for logging the current role  (Stephen Frost <sfrost@snowman.net>)
Re: Add support for logging the current role  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
On Wed, Jan 12, 2011 at 9:23 AM, Stephen Frost <sfrost@snowman.net> wrote:
> Minor enhancement, but a valuable one imv.  Hopefully there aren't any
> issues with it. :)

1. Why %o?  That's not obviously mnemonic.  Perhaps %U?

2. It won't be clear to people reading this what the difference is
between %u and this.  You probably need to reword the documentation
for the existing option as well as documenting the new one.

3. Please attach the patch rather than including it inline, if possible.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Ron Mayer
Date:
Subject: Re: Compatibility GUC for serializable
Next
From: Stephen Frost
Date:
Subject: Re: Add support for logging the current role