Memory allocation abstraction in pgcrypto - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Memory allocation abstraction in pgcrypto
Date
Msg-id A5BFAA1A-B2E8-4CBC-895E-7B1B9475A527@yesql.se
Whole thread Raw
Responses Re: Memory allocation abstraction in pgcrypto  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
pgcrypto has an abstraction for palloc/pfree via PX_OWN_ALLOC with the
intention to make it easy to swap out for another allocator.  There are however
a number of palloc calls that have snuck in over the years, so the abstraction
is leaking a fair bit making it less useful.  Since there have been no
complaints that I can see (searching the archives for PX_OWN_ALLOC yields zero
threads, and px_alloc none about this topic) then maybe it's time to remove it
and simplify the code?

The attached removes it in favor of using palloc() et.al directly.  Is there
any reason to keep it around still?

cheers ./daniel


Attachment

pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: Re: speed up unicode normalization quick check
Next
From: Andrew Dunstan
Date:
Subject: Re: XversionUpgrade tests broken by postfix operator removal