Re: headerscheck warnings with late-model gcc - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: headerscheck warnings with late-model gcc
Date
Msg-id 9b7ef918-302e-4c84-bc04-a37f5c2b5f92@eisentraut.org
Whole thread Raw
In response to headerscheck warnings with late-model gcc  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: headerscheck warnings with late-model gcc
List pgsql-hackers
On 05.08.25 20:09, Tom Lane wrote:
> Curiously, no such complaints appear with cpluspluscheck (which is
> using g++ 15.1.1).  I don't really understand why not: why would
> they have turned on -Wmissing-variable-declarations by default
> for C but not C++?  But anyway, since there doesn't seem to be
> any C++ compatibility issue here, I think it's sufficient to fix
> this in master and not back-patch.

-Wmissing-variable-declarations is added by us as of PG18 (commit 
66188912566).  It's available since gcc 14 and doesn't exist for C++.



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: analyze-in-stages post upgrade questions
Next
From: Nathan Bossart
Date:
Subject: Re: More protocol.h replacements this time into walsender.c