On 1/24/22, 9:16 PM, "Michael Paquier" <michael@paquier.xyz> wrote:
> Now, I also find confusing the state of CreateCheckpoint() once this
> patch gets applied. Now the code and comments imply that an
> end-of-recovery checkpoint is a shutdown checkpoint because they
> perform the same actions, which is fine. Could it be less confusing
> to remove completely the "shutdown" variable instead and replace those
> checks with "flags"? What the patch is doing is one step in this
> direction.
I looked into removing the "shutdown" variable in favor of using
"flags" everywhere, but the patch was quite messy and repetitive. I
think another way to make things less confusing is to replace
"shutdown" with an inverse variable called "online." The attached
patch does it this way.
Nathan
