Re: [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder - Mailing list pgsql-hackers

From MauMau
Subject Re: [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder
Date
Msg-id 9C8314399BC949BA8D1F2BC449C53FDB@maumau
Whole thread Raw
In response to Re: [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder  (Asif Naeem <anaeem.it@gmail.com>)
Responses Re: [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder
List pgsql-hackers
From: "Asif Naeem" <anaeem.it@gmail.com>
> Other than my pervious comments, patch looks good to me. Thanks.

Thanks for reviewing.  I understood that your previous comment was to 
suggest copying the desired DLLs directly from Release/Debug folder to bin. 
But I'm afraid it cannot be done cleanly...  CopySolutionOutput() copies all 
DLLS to lib folder with no exception as follows:
  if ($1 == 1)  {   $dir = "bin";   $ext = "exe";  }  elsif ($1 == 2)  {   $dir = "lib";   $ext = "dll";  }

It seems like I have to do something like this, listing the relevant DLL 
names anyway.  I don't think this is not cleaner.
  if ($1 == 1)  {   $dir = "bin";   $ext = "exe";  }  elsif ($1 == 2 && /* the project is libpq, libecpg, etc. */)  {
$dir= "bin";   $ext = "dll";  }  elsif ($1 == 2)  {   $dir = "lib";   $ext = "dll";  }
 

What do you think?  Am I misunderstanding your suggestion?

Regards
MauMau




pgsql-hackers by date:

Previous
From: Kouhei Kaigai
Date:
Subject: Re: [v9.5] Custom Plan API
Next
From: Robert Haas
Date:
Subject: Re: tweaking NTUP_PER_BUCKET