Re: Various silliness in heap_getnext and related routines - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Various silliness in heap_getnext and related routines
Date
Msg-id 9987.992105608@sss.pgh.pa.us
Whole thread Raw
In response to Re: Various silliness in heap_getnext and related routines  (bruc@stone.congenomics.com (Robert E. Bruccoleri))
Responses Re: Various silliness in heap_getnext and related routines  (bruc@stone.congenomics.com (Robert E. Bruccoleri))
List pgsql-hackers
bruc@stone.congenomics.com (Robert E. Bruccoleri) writes:
> For my immediate problem, would removing the spinlock acquisition
> be OK?

It'd be interesting to remove the marked lines:
    bufHdr = &BufferDescriptors[buffer - 1];
-        SpinAcquire(BufMgrLock);    if (bufHdr->tag.blockNum == blockNumber &&
RelFileNodeEquals(bufHdr->tag.rnode,relation->rd_node))    {
 
-            SpinRelease(BufMgrLock);        return buffer;    }
-        return ReadBufferWithBufferLock(relation, blockNumber, true);

and see how that affects your performance issue, if at all.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [JDBC] unlink large objects
Next
From: darcy@druid.net (D'Arcy J.M. Cain)
Date:
Subject: Re: ERROR: Memory exhausted in AllocSetAlloc(909324558)