Re: Feature improvement of tab completion for DEALLOCATE - Mailing list pgsql-hackers

On 2020/09/25 13:45, btnakamichin wrote:
> Hello!
> 
> I’d like to improve the deallocate tab completion.
> 
> The deallocate tab completion can’t complement “ALL”. Therefore, this patch fixes the problem.

Thanks for the patch! It looks basically good, but I think it's better
to add newline just before UNION to avoid long line, as follows.

-               COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements);
+               COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements
+                                                       " UNION SELECT 'ALL'");

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION