Re: Feature improvement of tab completion for DEALLOCATE - Mailing list pgsql-hackers

From btnakamichin
Subject Re: Feature improvement of tab completion for DEALLOCATE
Date
Msg-id 680a8129485eb754f31ad0ccc1f7151f@oss.nttdata.com
Whole thread Raw
In response to Re: Feature improvement of tab completion for DEALLOCATE  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: Feature improvement of tab completion for DEALLOCATE  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-hackers
2020-09-25 14:30 に Fujii Masao さんは書きました:
> On 2020/09/25 13:45, btnakamichin wrote:
>> Hello!
>> 
>> I’d like to improve the deallocate tab completion.
>> 
>> The deallocate tab completion can’t complement “ALL”. Therefore, this 
>> patch fixes the problem.
> 
> Thanks for the patch! It looks basically good, but I think it's better
> to add newline just before UNION to avoid long line, as follows.
> 
> -               
> COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements);
> +               
> COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements
> +                                                       " UNION SELECT 
> 'ALL'");
> 
> Regards,

Thank you, I appreciate your comment.

I have attached pattch with newline.

Regards,

NaokiNskamichi
Attachment

pgsql-hackers by date:

Previous
From: Ashutosh Sharma
Date:
Subject: Re: Logical replication from PG v13 and below to PG v14 (devel version) is not working.
Next
From: "Yang, Rong"
Date:
Subject: Problem of ko.po on branch REL9_5_STABLE