Re: pgsql: Move SQL-callable code related to multixacts into its own file - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Move SQL-callable code related to multixacts into its own file
Date
Msg-id 990166.1755692246@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Move SQL-callable code related to multixacts into its own file  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
List pgsql-committers
Bertrand Drouvot <bertranddrouvot.pg@gmail.com> writes:
> On Tue, Aug 19, 2025 at 11:27:25AM -0400, Tom Lane wrote:
>> I think "make world-bin"
>> or "make install-world" are the accepted targets for building everything.

> From what I can see, only:
> check-world:
> checkprep:
> installcheck-world:
> build src/test/modules.

I agree that this does not meet the principle of least surprise.
world-bin ought to build every bit of C code we have.

> I just found surprising that a "default" make (no target specified) does not
> build src/test/modules while a "default" meson/ninja does.

In itself that observation doesn't bother me: I don't think the
conventions in the Meson world are identical to those for makefiles.
We've long expected that contrib is not included in the default
make target, and it makes sense to me for src/test/modules to work
like contrib for this purpose.

            regards, tom lane



pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own file
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Minor error message enhancement