On 17.03.26 14:57, Peter Eisentraut wrote:
> On 16.03.26 16:54, Ashutosh Bapat wrote:
>> The patch looks fine to me. While reviewing it, I noticed that the
>> function has an extra loop to count the number of variables. I don't
>> think it's needed. The count can be obtained from the list length. In
>> the attached patch, I have removed that loop. Am I missing something?
>>
>> 0001 is your patch
>> 0002 removes the loop + some cosmetic changes
>
> committed
There are still some pg_upgrade-related failures on the buildfarm, but
AFAICT these are not specifically from this feature but more from the
test design of the PG_TEST_EXTRA="regress_dump_restore" test. It looks
like we need to drop all users at the end of
src/test/regress/sql/graph_table_rls.sql to make this work.
