ECPG patch causes warning - Mailing list pgsql-hackers

From Magnus Hagander
Subject ECPG patch causes warning
Date
Msg-id 9837222c1001100424h3f13881bpa2b146458a6b7356@mail.gmail.com
Whole thread Raw
Responses Re: ECPG patch causes warning
List pgsql-hackers
Hi!

The ecpg patch at
http://git.postgresql.org/gitweb?p=postgresql.git;a=commit;h=2f567552
causes a compile warning on win64 (andi think win32, but I didn't
recheck that). Specifically, line 140 of typename.c has:           return (-type);

Where type is of type Oid, which is unsigned. This causes the warning: .\src\interfaces\ecpg\ecpglib\typename.c(140):
warningC4146: unary
 
minus operator applied to unsigned type, result still unsigned


I think that line tries to fix that problem, but either it does it
wrong, or just in a way that MSVC can't deal with. I think you need to
cast it to a signed type as well?

-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/


pgsql-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: Congrats Alvaro!
Next
From: Tim Bunce
Date:
Subject: Re: Initial refactoring of plperl.c - updated