Re: Initial refactoring of plperl.c - updated - Mailing list pgsql-hackers

From Tim Bunce
Subject Re: Initial refactoring of plperl.c - updated
Date
Msg-id 20100110122932.GG2481@timac.local
Whole thread Raw
In response to Re: Initial refactoring of plperl.c - updated  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Initial refactoring of plperl.c - updated
List pgsql-hackers
On Sun, Jan 10, 2010 at 01:16:13AM -0500, Tom Lane wrote:
> Tim Bunce <Tim.Bunce@pobox.com> writes:
> > On Sat, Jan 09, 2010 at 11:16:18PM +0200, Peter Eisentraut wrote:
> >> What's the reason for the temp file here?
>
> > Defensive. If the text2macro.pl program fails/dies then you'd be left
> > with a broken output file with a newer timestamp, so the next make
> > wouldn't rerun text2macro.pl.
>
> Doesn't make forcibly remove the target file if the command fails?
>
> [ rummages in manual... ]  It does if you specify .DELETE_ON_ERROR,
> which we do (in Makefile.global); so this bit of complication is
> a waste.

Okay.

Andrew, perhaps you could apply the attached to fix that.  (Or I could
bundle it into one of the split out plperl feature patches.)

Tim.


Attachment

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: ECPG patch causes warning
Next
From: James Mansion
Date:
Subject: Re: win32 socket definition