Postgres Pro
Downloads
Home   >   mailing lists

Re: A minor correction in comment in heaptuple.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: A minor correction in comment in heaptuple.c
Date
Msg-id 9702.1390686819@sss.pgh.pa.us
Whole thread Raw
In response to Re: A minor correction in comment in heaptuple.c  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Tree view 
Andres Freund <andres@2ndquadrant.com> writes:
> On 2014-01-25 16:28:09 -0500, Bruce Momjian wrote:
>> Is everyone OK with me applying this patch from Kevin, attached?

> No. I still think this is stupid. Not at all clearer and possibly breaks
> stuff.

I agree; this patch is flat out wrong.  It converts a valid situation
which is correctly handled into an Assert trap, or probably a core dump
in a non-assert build.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: What is happening on buildfarm member crake?
Next
From: Bruce Momjian
Date:
Subject: Re: A better way than tweaking NTUP_PER_BUCKET