Re: A minor correction in comment in heaptuple.c - Mailing list pgsql-hackers

From Andres Freund
Subject Re: A minor correction in comment in heaptuple.c
Date
Msg-id 20140125212936.GX7182@awork2.anarazel.de
Whole thread Raw
In response to Re: A minor correction in comment in heaptuple.c  (Bruce Momjian <bruce@momjian.us>)
Responses Re: A minor correction in comment in heaptuple.c  (Bruce Momjian <bruce@momjian.us>)
Re: A minor correction in comment in heaptuple.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2014-01-25 16:28:09 -0500, Bruce Momjian wrote:
> On Tue, Jun 18, 2013 at 11:04:25AM -0700, Kevin Grittner wrote:
> > D'Arcy J.M. Cain <darcy@druid.net>
> >
> > > Although, the more I think about it, the more I think that the comment
> > > is both confusing and superfluous.  The code itself is much clearer.
> >
> > Seriously, if there is any comment there at all, it should be a
> > succinct explanation for why we didn't do this (which passes `make
> > check-world`):
>
> Is everyone OK with me applying this patch from Kevin, attached?

No. I still think this is stupid. Not at all clearer and possibly breaks
stuff.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: A minor correction in comment in heaptuple.c
Next
From: Bruce Momjian
Date:
Subject: Re: A minor correction in comment in heaptuple.c