Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.
Date
Msg-id 9701.1503973584@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problemswhen copying files >2GB.  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problemswhen copying files >2GB.  (Michael Paquier <michael.paquier@gmail.com>)
Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problemswhen copying files >2GB.  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> I don't like breaking the abstraction of pg_log() with the existing
> flags with some kind of pg_debug() layer. The set of APIs present now
> in pg_rewind for logging is nice to have, and I think that those debug
> messages should be translated. So what about the attached?

Your point about INT64_FORMAT not necessarily working with fprintf
is an outstanding reason not to keep it like it is.  I've not reviewed
this patch in detail but I think this is basically the way to fix it.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problemswhen copying files >2GB.
Next
From: yangjie
Date:
Subject: Re: [HACKERS] hash partitioning based on v10Beta2