Re: [feature]COPY FROM enable FORCE_NULL/FORCE_NOT_NULL on all columns - Mailing list pgsql-hackers

On Jul 9, 2023 at 11:51 +0800, Zhang Mingli <zmlpostgres@gmail.com>, wrote:

HI, 

Regards,

Zhang Mingli

On Jul 7, 2023, 18:00 +0800, Damir Belyalov <dam.bel07@gmail.com>, wrote:

The patch does not work for the current version of postgres, it needs to be updated.

I tested your patch. Everything looks simple and works well.

There is a suggestion to simplify the code: instead of using

if (cstate->opts.force_notnull_all)

{

int i;

for(i = 0; i < num_phys_attrs; i++)

cstate->opt.force_notnull_flags[i] = true;

}

Thanks very much for review. 

Nice suggestion, patch rebased and updated.

V2 patch still have some errors when apply file doc/src/sgml/ref/copy.sgml, rebased and fixed it in V3 path.

Thanks a lot for review.