Re: pgstattuple locking fix - Mailing list pgsql-patches

From Tom Lane
Subject Re: pgstattuple locking fix
Date
Msg-id 9494.1193073664@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgstattuple locking fix  ("Heikki Linnakangas" <heikki@enterprisedb.com>)
List pgsql-patches
"Heikki Linnakangas" <heikki@enterprisedb.com> writes:
> ITAGAKI Takahiro wrote:
>> Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> I'm thinking that having a pin on the buffer should be enough to
>>> call PageGetHeapFreeSpace.
>>
>> Hmm... we might use pd_upper and pd_lower at different times,

> No I think the original patch was right. You can indeed read
> inconsistent values for pd_upper and pd_lower, though the window is very
> small.

Good point.  I'll apply the original patch and also Heikki's suggested
comment.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: EXECUTE USING for plpgsql (for 8.4)
Next
From: Tom Lane
Date:
Subject: Re: pgstattuple locking fix