Re: pgstattuple locking fix - Mailing list pgsql-patches

From Tom Lane
Subject Re: pgstattuple locking fix
Date
Msg-id 16712.1193074326@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgstattuple locking fix  ("Heikki Linnakangas" <heikki@enterprisedb.com>)
List pgsql-patches
"Heikki Linnakangas" <heikki@enterprisedb.com> writes:
> On second thought, we do call PageGetHeapFreeSpace without holding a
> lock in heap_page_prune_opt as well, so it better be safe. Looking
> closer at PageGetHeapFreeSpace, I think it is. The
> return value can be bogus, of course.

> That's worth noting in the comments:

On closer look, the comments in heap_page_prune_opt seem to address
the issue already, and I'm not sure why we should comment
PageGetHeapFreeSpace this way but not all the other variants in
bufpage.c.

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgstattuple locking fix
Next
From: "Gokulakannan Somasundaram"
Date:
Subject: Re: [HACKERS] Including Snapshot Info with Indexes